On 10/26/17 1:41 AM, Nicolas Dichtel wrote: >> So I found this the first timer around when looking at this code, but was >> told that >> notification are expected anytime we modified any setting thus the code was >> simply >> checking for MODIFIED bit. Has that thinking changed? > No, you're right, thank you for pointing this out. I was focus on the > duplicated > notifications and forget the initial goal. > > I will ask for a revert.
For everyone of the MODIFIED but not NOTIFY is there already a message sent? If so, no revert is needed. If not, then perhaps those need the NOTIFY bit set.
