On 10/26/2017 2:29 PM, Nambiar, Amritha wrote:
On 10/11/2017 4:30 PM, Shannon Nelson wrote:
On 10/10/2017 5:24 PM, Amritha Nambiar wrote:
[...]
+ /* For Geneve, the VNI should be placed in offset shifted by a
+ * byte than the offset for the Tenant ID for rest of the
This comment isn't quite clear - maybe s/than/then/ ?
How about, "For Geneve, the VNI should begin at an offset shifted by a
byte compared to the offset normally used for the Tenant ID for other
tunnel types" ?
Or maybe "Due to hardware eccentricities, the VNI for Geneve is shifted
one more byte further than normally used for Tenant ID in other tunnel
types"
[...]
+ dev_err(&pf->pdev->dev, "Bad src port mask
0x%04x\n",
Consider using %pI4
For ports, I'll keep the 0x%04x. I'll change to %pI4 for the IPv4
address masks.
Oh, right, that one's a port.
sln
