From: Guillaume Nault <g.na...@alphalink.fr> Date: Fri, 27 Oct 2017 16:51:48 +0200
> Currently l2tp_session_create() allocates a session, partially > initialises it and finally registers it. It therefore exposes sessions > that aren't fully initialised to the rest of the system, because > pseudo-wire specific initialisation can only happen after > l2tp_session_create() returns. > This leads to several crashes when these sessions are used or deleted. > > This series starts by splitting session registration out of > l2tp_session_create() (patch #1). Thus allowing pseudo-wires code to > terminate the initialisation phase before registration. > > Then patch #2 fixes the eth pseudo-wire code. This requires protecting > the session's netdevice pointer with RCU, because it still needs to be > updated concurrently after the session got registered. > > Remaining patches take care of ppp pseudo-wires. RCU protection is > needed there too, for the same reasons. This time it's the pppol2tp > socket pointer that gets protected. For clarity, and since the > conversion requires more modifications, introducing RCU is done in > its own patch (#3). Then patch #4 only has to take care of fixing > sessions initialisation and registration (and adapting part of the > deletion process). Series applied, thank you.
