On 10/30/2017 11:46 AM, Vivien Didelot wrote:
> Hi Florian,
>
> Florian Fainelli <f.faine...@gmail.com> writes:
>
>> Reviewed-by: Florian Fainelli <f.faine...@gmail.com>
>>
>> One nit below:
>>
>>> static int dsa_port_parse_of(struct dsa_port *dp, struct device_node *dn)
>>> {
>>> + struct device_node *ethernet = of_parse_phandle(dn, "ethernet", 0);
>>> + struct device_node *link = of_parse_phandle(dn, "link", 0);
>>> +
>>> + if (ethernet) {
>>> + dp->type = DSA_PORT_TYPE_CPU;
>>> + } else if (link) {
>>> + dp->type = DSA_PORT_TYPE_DSA;
>>> + } else {
>>> + dp->type = DSA_PORT_TYPE_USER;
>>> + }
>>> +
>>
>> The curly braces are probably not necessary since all of these are
>> single line statements.
>
> I didn't mention it in the commit message because it was obvious that
> the next patches will extend these condition arms.
Fair enough then ;)
--
Florian
