On Thu, Nov 02, 2017 at 05:06:47AM -0700, Pravin Shelar wrote: > On Wed, Nov 1, 2017 at 7:50 PM, Yang, Yi <yi.y.y...@intel.com> wrote: > > On Thu, Nov 02, 2017 at 08:52:40AM +0800, Pravin Shelar wrote: > >> On Tue, Oct 31, 2017 at 9:03 PM, Yi Yang <yi.y.y...@intel.com> wrote: > >> > > >> > OVS master and 2.8 branch has merged NSH userspace > >> > patch series, this patch is to enable NSH support > >> > in kernel data path in order that OVS can support > >> > NSH in compat mode by porting this. > >> > > >> > Signed-off-by: Yi Yang <yi.y.y...@intel.com> > >> > --- > >> I have comment related to checksum, otherwise patch looks good to me. > > > > Pravin, thank you for your comments, the below part is incremental patch > > for checksum, please help check it, I'll send out v16 with this after > > you confirm. > > > This change looks good to me. > I noticed couple of more issues. > 1. Can you move the ovs_key_nsh to the union of ipv4 an ipv6? > ipv4/ipv6/nsh key data is mutually exclusive so there is no need for > separate space for nsh key in the ovs key. > 2. We need to fix match_validate() with nsh check. Datapath can not > allow any l3 or l4 match if the flow key contains nsh match and > vice-versa. such flow key should be rejected.
Ok, I'll fix them ASAP.
