On Fri, 03 Nov 2017 10:19:22 -0700
Greg Greenway <ggreen...@apple.com> wrote:
> On Nov 1, 2017, at 2:03 PM, Stephen Hemminger <step...@networkplumber.org>
> wrote:
> >
> > On Tue, 31 Oct 2017 13:00:47 -0700
> > Greg Greenway <ggreen...@apple.com> wrote:
> >
> >> + if (tb[FOU_ATTR_AF]) {
> >> + family = rta_getattr_u8(tb[FOU_ATTR_AF]);
> >> + if (family == AF_INET)
> >> + family_str = "AF_INET";
> >> + else if (family == AF_INET6)
> >> + family_str = "AF_INET6";
> >> + else
> >> + family_str = "unknown";
> >> + fprintf(fp, "af %s ", family_str);
> >
> > The unwritten rule for ip commands is that the show function
> > must format the output with same command syntax as the other commands
> > set/add/delete.
> > Since there is no "af AF_INET" option to ip fou, this breaks that
> > convention.
> > Either ignore the address family, change the add command, or output with
> > same
> > syntax (-6); preferably the latter.
>
> That makes sense. Here's a corrected version. It also avoids a
> trailing-space in the output.
Yes, your followup looks correct but since it didn't follow the mailing list
patch protocol it was not picked up and managed by patchwork.
https://patchwork.ozlabs.org/patch/832717/
You need to post the patch as new patch (ie not a followup) with the "v2"
designation
in order to get it correctly picked up and managed by patchwork.
