On Tue, Nov 21, 2017 at 04:15:57PM +0100, Tobias Jakobi wrote:
> Commit 6fa1ba61520576cf1346c4ff09a056f2950cb3bf partially
> implemented the new ethtool API, by replacing get_settings()
> with get_link_ksettings(). This breaks ethtool, since the
> userspace tool (according to the new API specs) never tries
> the legacy set() call, when the new get() call succeeds.
>
> All attempts to chance some setting from userspace result in:
> > Cannot set new settings: Operation not supported
>
> Implement the missing set() call.
>
> Signed-off-by: Tobias Jakobi <[email protected]>
Fixes: 6fa1ba615205 ("net: realtek: r8169: use new api
ethtool_{get|set}_link_ksettings")
It would be good to have this in stable.
Reviewed-by: Andrew Lunn <[email protected]>
Andrew
