> On Dec 1, 2017, at 2:09 PM, Stefan Hajnoczi <stefa...@redhat.com> wrote: > > On Thu, Nov 30, 2017 at 01:21:26PM +0000, Jorgen S. Hansen wrote: >>> On Nov 30, 2017, at 12:21 PM, Stefan Hajnoczi <stefa...@redhat.com> wrote: > > Thanks for the quick review! > > I forgot to ask you: Is SOCK_DGRAM reliable and in-order over VMCI?
No, that isn’t guaranteed. > >>> +.PP >>> +Valid socket types are >>> +.B SOCK_STREAM >>> +and >>> +.B SOCK_DGRAM . >> >> The space here results in a space between SOCK_DGRAM and the “.” in the >> formatted text. Is that intentional? > > I haven't figured out the groff syntax to avoid the space :(. Any > ideas? Looks like man 7 unix has a few examples with bold and “,” - maybe look at the source for that. > >> Apart from the nits, this looks great. > > Please let me know if there are any other topics that we should cover in > the man page. Sure, I’ll get back to you soon, if I think of anything. Thanks, Jorgen
