On Fri, Dec 8, 2017 at 2:09 PM, Marcelo Ricardo Leitner <marcelo.leit...@gmail.com> wrote: > Hi, > > On Thu, Dec 07, 2017 at 03:03:35AM -0500, Michael Chan wrote: >> --- a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c >> +++ b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c >> @@ -940,6 +940,9 @@ int qede_change_mtu(struct net_device *ndev, int new_mtu) >> DP_VERBOSE(edev, (NETIF_MSG_IFUP | NETIF_MSG_IFDOWN), >> "Configuring MTU size of %d\n", new_mtu); >> >> + if (new_mtu > PAGE_SIZE) > > I don't know the specs for this card but if it needs to fit the whole > packet in a page, maybe it should consider the ethernet header size in > such checks? >
I am not changing the logic in this patch, just moving the check from qede_alloc_sge_mem() to qede_fix_features(). Typically, the chip will also do header-data split when doing GRO_HW, so that's probably why it is checking the MTU and not the total packet size against page size. Ariel can confirm.
