Re: [PATCHv2 2/3] net: socionext: Add Synquacer NetSec driver

[Jassi Brar]

On Wed, Dec 13, 2017 at 2:18 AM, Andrew Lunn <and...@lunn.ch> wrote:
>> > +static int netsec_mac_update_to_phy_state(struct netsec_priv *priv)
>> > +{
>> > +       struct phy_device *phydev = priv->ndev->phydev;
>> > +       u32 value = 0;
>> > +
>> > +       value = phydev->duplex ? NETSEC_GMAC_MCR_REG_FULL_DUPLEX_COMMON :
>> > +                                NETSEC_GMAC_MCR_REG_HALF_DUPLEX_COMMON;
>> > +
>> > +       if (phydev->speed != SPEED_1000)
>> > +               value |= NETSEC_MCR_PS;
>> > +
>> > +       if (priv->phy_interface != PHY_INTERFACE_MODE_GMII &&
>> > +           phydev->speed == SPEED_100)
>> > +               value |= NETSEC_GMAC_MCR_REG_FES;
>> > +
>> > +       value |= NETSEC_GMAC_MCR_REG_CST | NETSEC_GMAC_MCR_REG_JE;
>> > +
>> > +       if (priv->phy_interface == PHY_INTERFACE_MODE_RGMII)
>> > +               value |= NETSEC_GMAC_MCR_REG_IBN;
>
> phy_interface_mode_is_rgmii() ??
>
Yes, thank you.