Hi! > > > > Any ideas ? > > > > > > Yes , 19110cfbb34d4af0cdfe14cd243f3b09dc95b013 broke it. > > > > > > See: > > > https://bugzilla.kernel.org/show_bug.cgi?id=198047 > > > > > > Fix there : > > > https://marc.info/?l=linux-kernel&m=151272209903675&w=2 > > > > > > Regards, > > > > > > Gabriel C > > > > Hi, > > > > Digging into this, the problem is complicated. The original bug assumed > > behavior > > of the .check_for_link call, which is universally not implemented. > > > > I think the correct fix is to revert 19110cfbb34d ("e1000e: Separate > > signaling for > > link check/link up", 2017-10-10) and find a more proper solution. > > > > I don't think any other code which uses check_for_link expects the > > interface to > > return in the way this patch attempted.
> Alternatively, we can go a step farther and make sure every implementation of
> .check_for_link follows the modified interface.
>
We are at -rc3 now. Reverting 19110cfbb34d seems like good solution at
the moment.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
signature.asc
Description: Digital signature
