From: Jakub Kicinski <jakub.kicin...@netronome.com> Date: Tue, 19 Dec 2017 15:46:51 -0800
> On Tue, 19 Dec 2017 16:05:23 +0200, Tomer Tayar wrote: >> Sorry for the very long patch. >> The firmware changes are spread all over w/o a good modularity. > > Rings false. Significant portion of this patch is just whitespace > and comment changes. Totally agreed. This thing is beyond huge already, adding unrelated whitespace and comment changes make reviewing it even more impossible.