On Wed, 2017-12-20 at 22:07 +0100, Christian Lamparter wrote: > > > will read this and say "Oh the function tests against these weird > > PHY_MODE_* aliases, but the helper function phy_interface_mode_is_rgmii() > > tests against PHY_INTERFACE_MODE_*, what is going on?" > > > > I hate to do this to you, but please get rid of these confusing and > > completely unnecessary PHY_MODE_* CPP aliases first, and just use the > > proper PHY_INTERFACE_MODE_* values consistently. > > Yeah, I can do that. no problem. > > Question is, should I also replace the rgmii_mode_name() with phy_modes() too? > > The only user of rgmii_mode_name() is this notice printk in rgmii_attach(): > <http://elixir.free-electrons.com/linux/latest/source/drivers/net/ethernet/ibm/emac/rgmii.c#L117>
Yup, this is all pre-hisorical gunk, feel free to replace it. Cheers, Ben.
