On Thu, Dec 21, 2017 at 09:50:52PM +0100, Heiner Kallweit wrote: > @@ -1188,21 +1188,6 @@ static void rtl_w0w1_phy(struct rtl8168_private *tp, > int reg_addr, int p, int m) > rtl_writephy(tp, reg_addr, (val & ~m) | p); > } > > -static void rtl_mdio_write(struct net_device *dev, int phy_id, int location, > - int val) > -{ > - struct rtl8168_private *tp = netdev_priv(dev); > - > - rtl_writephy(tp, location, val); > -} > - > -static int rtl_mdio_read(struct net_device *dev, int phy_id, int location) > -{ > - struct rtl8168_private *tp = netdev_priv(dev); > - > - return rtl_readphy(tp, location); > -}
Hi Heiner With these two gone, it would be nice to rename r8168_mdio_read_reg() and r8168_mdio_write_reg() to rtl_mdio_read() and rtl_mdio_write(). Andrew