Am 22.12.2017 um 11:00 schrieb Andrew Lunn:
>> static int rtl8168_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
>> {
>> - struct rtl8168_private *tp = netdev_priv(dev);
>> - struct mii_ioctl_data *data = if_mii(ifr);
>> + if (!netif_running(dev))
>> + return -ENODEV;
>
> It is sometimes useful to be able to prod and poke the PHY when the
> MAC is not running. Is this limit because of power saving?
>
Actually I'm not 100% sure, I just kept the existing logic.
When checking other users of phy_mii_ioctl I saw that it is
a typical pattern to return an error if the interface is down.
> Otherwise, this patch looks good.
>
> Thanks
> Andrew
>
