Wed, Jan 03, 2018 at 07:29:46PM CET, d...@cumulusnetworks.com wrote: >On 1/3/18 11:17 AM, Jiri Pirko wrote: >> Wed, Jan 03, 2018 at 07:14:16PM CET, d...@cumulusnetworks.com wrote: >>> On 1/3/18 11:05 AM, Arkadi Sharshevsky wrote: >>>> As I stated this is a user-space bug which I fixed, and updated my repo >>>> so please pull. Devlink uses mnl,and currently mnl does not support >>>> extended ack. I added support for this in my local ver of libmnl: >>>> >>>> https://github.com/arkadis/libmnl.git >>>> >>>> On branch master, so you can check it out. Besides this bugs, which were >>>> userspace, can please specify what are the pending problems from your >>>> point of view? Thanks! >>> >>> devlink is in iproute2 package and it has extack support. See 'git log >>> lib/libnetlink.c' >> >> Dave, devlink uses libmnl. >> > >Now I remember. You wrote it independently and but needed iproute2 be a >delivery vehicle. It uses none of the common infrastructure from >iproute2. Could we make this more difficult ....
Feel free to rewrite it to use lib/libnetlink.c. Should not be that hard. Note that at the time I was pushing devlink userspace, tipc also used libmnl as a part of iproute2, so devlink was not the first one. That is why I decided not to rewrite. As of the rest of the "common infrastructure", what exactly do you have in mind? > >Sometime in the next day I will jump through the hoops to get a proper >devlink command.
