On Wed, Aug 30, 2006 at 10:43:39AM +0200, Johannes Berg wrote: > This patch converts uses of list_for_each and list_for_each_safe to > list_for_each_entry and list_for_each_entry_safe respectively where > applicable. It also adds locking in some places though I'm not entirely > sure that I can do it that way (i.e. call ieee80211_key_enable_hwaccel > etc. with spinlocks held).
Could you please separate cleanup parts (list_for_each changes) from functional changes (adding locking) to make it easier to review the patch? I would prefer not to hold spinlocks when calling registered callbacks from the hardware driver. At minimum, this would need to be documented very clearly to make sure that whoever is writing low-level drivers would be aware of this. In general, it would just be simpler if this can be avoided altogether. -- Jouni Malinen PGP id EFC895FA - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
