On Tue, Jan 9, 2018 at 10:21 AM, Ben Hutchings <ben.hutchi...@codethink.co.uk> wrote: > Commit 15e668070a64 reordered the initialisation in inet6_init() to > fix a crash on an error path further down the call stack. It also > reordered cleanup on the error path in inet6_init(), but the result > is not the reverse of the initialisation order. This presumably > can result in a resource leak or crash in some error cases. Reorder > cleanup again to fix this.
Can you be specific on what resource we leak here? Also, it looks like you not just revert the order changed in commit 15e668070a64, but also you move icmpv6_cleanup() even earlier.