Oliver Neukum <oneu...@suse.com> writes:
> That a kevent could not be scheduled is not an error.
> Such handlers must be able to deal with multiple events anyway.
> As the successful scheduling of a work is a debug event, make
> the failure debug priority, too.
>
> Signed-off-by: Oliver Neukum <oneu...@suse.com>
> Reported-by: Cristian Caravena <carav...@gmail.com>
> ---
> drivers/net/usb/usbnet.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
> index d56fe32bf48d..1e0bbe23f95c 100644
> --- a/drivers/net/usb/usbnet.c
> +++ b/drivers/net/usb/usbnet.c
> @@ -458,8 +458,7 @@ void usbnet_defer_kevent (struct usbnet *dev, int work)
> {
> set_bit (work, &dev->flags);
> if (!schedule_work (&dev->kevent)) {
> - if (net_ratelimit())
> - netdev_err(dev->net, "kevent %d may have been
> dropped\n", work);
> + netdev_dbg(dev->net, "kevent %d may have been dropped\n", work);
> } else {
> netdev_dbg(dev->net, "kevent %d scheduled\n", work);
> }
Great! But why do you drop the ratelimit? This can be very noisy when
it hits. I'd like to keep it ratelimited.
But if you do decide to drop the limit, then you'll have to clean up the
braces...
Bjørn
