On Mon, Jan 15, 2018 at 10:37 PM, Jason Wang <jasow...@redhat.com> wrote: > > > On 2018年01月16日 14:33, Cong Wang wrote: >> But __tun_detach(true) is not a hot path, a memset() doesn't harm >> anything. > > > Yes, but it looks more more like a workaround or trick to me. >
I'd blame skb_array API for this. ;) Ideally, skb_array_cleanup() should take care of everything I put in tun_cleanup_tx_array(). As I mentioned in changelog, we can always improve it in -net-next, so I don't want to bother it for -net.
