Ananda, Herbert Xu recently found a problem in the TCP stack
input path for LRO capable receive paths.

The issue is that the receive MSS estimator in
tcp_measure_rcv_mss() uses skb->len for the MSS
estimation.  This is wrong for LRO frames.

Herbert noticed this using Xen which pused TSO frames
on output back into the destination TCP stack on input
so it looks exactly like LRO.

His fix to tcp_measure_rcv_mss() is to use
skb_shared_info(skb)->gso_size if it is non-zero,
else skb->len, in the assignment to "len".

So could you please make the S2io driver LRO path
set skb_shared_info(skb)->gso_size appropriately?
Probably the easiest is to use the length of the
first frag of a multiple frag LRO sequence.

Also, could we have a linux/MAINTAINERS entry added
for the S2io driver?

Thanks.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to