On Mon, Jan 22, 2018 at 2:44 PM, Cong Wang <xiyou.wangc...@gmail.com> wrote: > > Good point, but netdev_for_each_tx_queue() doesn't handle errors > in current code base, it is not trivial to make it returning int to reflect > errors, since we have to rollback a partial failure too.
I think for now we can just check for errors but not rollback, at least attach_default_qdiscs() does not rollback either. And I will add a comment saying we need to do it in future.
