Hi Rafael, 2018-01-24 3:08 GMT+01:00 Rafael J. Wysocki <raf...@kernel.org>: > On Tue, Jan 23, 2018 at 7:12 AM, Marcin Wojtas <m...@semihalf.com> wrote: >> Hi Rafael, >> >>> > if (res) >>> > return res; >>> > >>> > - return device_get_mac_addr(dev, "address", addr, alen); >>> > + return fwnode_get_mac_addr(fwnode, "address", addr, alen); >>> > +} >>> > +EXPORT_SYMBOL(fwnode_get_mac_address); >>> >>> That should be EXPORT_SYMBOL_GPL(). >>> >>> I have overlooked that previously, sorry about that. >> >> The series landed yesterday in net-next, so I need to send a fix on >> top. > > OK > >> Would you be ok with single patch fixing all EXPORT_SYMBOL() >> occurences? Those would be 2 new routines: >> - fwnode_get_mac_address >> - fwnode_irq_get >> and 2 already existing in the file: >> - device_get_mac_address >> - fwnode_graph_parse_endpoint >> >> Please let know, how you prefer to handle it? > > I guess it's better to fix this up when the series gets merged. >
Ok, I will do it at that time. Thanks, Marcin
