Hello! > This path obviously breaks assumption 1) and therefore can lead to ABBA > dead-locks.
Yes... > I've looked at the history and there seems to be no reason for the lock > to be held at all in dev_watchdog_up. The lock appeared in day one and > even there it was unnecessary. Seems, it serializes mod_timer and timer handler to keep timer in predictable state. Maybe, this is not necessary. A priori, it is required. Note that in dev_watchdog_down() queue_lock is released before taking xmit_lock. Probably, this is the thing which was supposed to be done in dev_watchdog_up() too. Alexey -- VGER BF report: U 0.46385 - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html