Hi! This set makes most drivers use a new tc_cls_can_offload_and_chain0() helper which will set extack in case TC hw offload flag is disabled. i40e patch will follow after net -> net-next merge.
I chose to keep the new helper which also looks at the chain but renamed it more appropriately. The rationale being that most drivers don't accept chains other than 0 and since we have to pass extack to the helper we can as well pass the entire struct tc_cls_common_offload and perform the most common checks. Jiri, please let me know if that's acceptable for you. This code makes the assumption that type_data in the callback can be interpreted as struct tc_cls_common_offload, i.e. the real offload structure has common part as the first member. This allows us to make the check once for all classifier types if driver supports more than one. This also means I've dropped the last patch of the RFC (preventing use of common before type validation in nfp). Jakub Kicinski (8): pkt_cls: add new tc cls helper to check offload flag and chain index bnxt: use tc_cls_can_offload_and_chain0() nfp: flower: use tc_cls_can_offload_and_chain0() cxgb4: use tc_cls_can_offload_and_chain0() ixgbe: use tc_cls_can_offload_and_chain0() mlx5: use tc_cls_can_offload_and_chain0() mlxsw: use tc_cls_can_offload_and_chain0() selftests/bpf: check for spurious extacks from the driver drivers/net/ethernet/broadcom/bnxt/bnxt.c | 3 ++- drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c | 3 --- drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c | 3 ++- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 8 +------ drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 5 +--- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 5 +--- drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 5 +--- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 6 ++--- drivers/net/ethernet/netronome/nfp/bpf/main.c | 4 +--- .../net/ethernet/netronome/nfp/flower/offload.c | 7 +++--- drivers/net/netdevsim/bpf.c | 5 +--- include/net/pkt_cls.h | 12 ++++++++++ tools/testing/selftests/bpf/test_offload.py | 27 ++++++++++++++++++++++ 13 files changed, 54 insertions(+), 39 deletions(-) -- 2.15.1
