From: Yury Norov <yno...@caviumnetworks.com> Date: Tue, 6 Feb 2018 20:03:13 +0300
> On Tue, Feb 06, 2018 at 11:42:18AM -0500, David Miller wrote: >> From: Yury Norov <yno...@caviumnetworks.com> >> Date: Tue, 6 Feb 2018 19:26:23 +0300 >> >> > On Tue, Feb 06, 2018 at 11:17:36AM -0500, David Miller wrote: >> >> From: Heiner Kallweit <hkallwe...@gmail.com> >> >> Date: Mon, 5 Feb 2018 07:21:32 +0100 >> >> >> >> > Recently ethtool started to give incomplete values for supported and >> >> > advertised modes. There seems to be a regression in this commit: >> >> > The bit number parameter in the calls to bitmap_to_arr32() in >> >> > store_link_ksettings_for_user() should be __ETHTOOL_LINK_MODE_MASK_NBITS >> >> > instead of __ETHTOOL_LINK_MODE_MASK_NU32. >> >> > >> >> > After having changed this ethtool behaves normally again. >> >> >> >> I do not see the commit with the SHA1 ID from the Subject line in >> >> either Linus's nor my networking tree. >> >> >> >> Where is that change? >> > >> > It's in next-20180202. >> >> Hmmm, then the fix should probably go into whatever tree that commit >> ultimately came from. > > It's already in Andrew's tree. The original patch is not about networking, > and Andrew's tree is probably better place for fix. My apologies for noise > in your tree. > > http://ozlabs.org/~akpm/mmots/broken-out/bitmap-replace-bitmap_fromto_u32array-fix-2.patch Thanks for the clarification.