On 2/11/18 4:48 PM, Stephen Hemminger wrote:
> On Sun, 11 Feb 2018 22:02:30 +0200
> Serhey Popovych <serhe.popov...@gmail.com> wrote:
> 
>> +static inline void inet_prefix_reset_flags(inet_prefix *p)
>> +{
>> +    p->flags = 0;
>> +}
> 
> Just do it.
> 
> Wrapper adds nothing here.
> 

I asked for a wrapper to flags b/c embedding 'p->flags = 0' into code
hides what it is doing - which is resetting the address type in
inet_prefix. If inet_prefix is hiding address family and address type
details from the main ip code, details of how it works should be opaque
to that code.

Reply via email to