From: Jesper Dangaard Brouer <[email protected]> Date: Tue, 13 Feb 2018 17:59:22 +0100
> This reverts commit aa136d0c82fcd6af14535853c30e219e02b2692d. > > As I previously[1] pointed out this implementation of XDP_REDIRECT is > wrong. XDP_REDIRECT is a facility that must work between different > NIC drivers. Another NIC driver can call ndo_xdp_xmit/nicvf_xdp_xmit, > but your driver patch assumes payload data (at top of page) will > contain a queue index and a DMA addr, this is not true and worse will > likely contain garbage. > > Given you have not fixed this in due time (just reached v4.16-rc1), > the only option I see is a revert. > > [1] http://lkml.kernel.org/r/[email protected] > > Cc: Sunil Goutham <[email protected]> > Cc: Christina Jacob <[email protected]> > Cc: Aleksey Makarov <[email protected]> > Fixes: aa136d0c82fc ("net: thunderx: Add support for xdp redirect") > Signed-off-by: Jesper Dangaard Brouer <[email protected]> Applied, thanks Jesper.
