Hi, On Thu, Feb 15, 2018 at 6:14 AM, Davide Caratti <dcara...@redhat.com> wrote: > On Wed, 2018-02-14 at 17:13 -0500, Alexander Aring wrote: >> This patch adds extack support for generic act handling. The extack >> will be set deeper to each called function which is not part of netdev >> core api. >> >> Based on work by David Ahern <dsah...@gmail.com> > > hello Alexander, > > after looking at the code more closely, I think there is margin for some > more improvement here (i.e make the message contents easier to grep from a > log). Please let me know if the comments below make sense for you. >
I will send v3 with your changes. But not with one error handling in label, the most whole point is to get some messages when somebody throw a -EINVAL to the userspace and TC subsystem has a lot of places with that. - Alex