On 18-02-15 09:50 AM, Davide Caratti wrote:
When tca_action_flush() calls the action walk() and gets an error, a successful call to nla_nest_start() is not followed by a call to nla_nest_cancel(). It's harmless, as the skb is freed in the error path - but it's worth to fix this unbalance.
Kind of pushing the boundaries saying this targets net tree - there is no bug you are fixing (as you say the sk is freed). Maybe it makes the code prettier ... cheers, jamal
