From: Rahul Lakkireddy <rahul.lakkire...@chelsio.com> Date: Thu, 15 Feb 2018 19:24:42 +0530
> Register callback to panic_notifier_list. Invoke dump collect routine > to append dump to vmcore. > > Signed-off-by: Rahul Lakkireddy <rahul.lakkire...@chelsio.com> > Signed-off-by: Ganesh Goudar <ganes...@chelsio.com> There is absolutely no precedence for a networking driver dumping things into the vmcore image on a panic. And I don't think this is a good idea. Really, this commit message should have explained why this is desired and in what context it is legitimate for this driver in particular to do it. A very detailed, long, complete commit message is especially important when you are deciding to blaze you own trail and do something no other networking driver has done before. I get really upset when I see changes like this, because you give me no preparation for what I'm about to read in the patch and therefore I have to go into this routine asking you to explain things properly. But as-is, I see this panic notifier as a really bad idea. Thanks.
