On Mon, Feb 19, 2018 at 12:32 PM, Roman Kapl <c...@rkapl.cz> wrote: > So far, if the filter was too large to fit in the allocated skb, the > kernel did not return any error and stopped dumping. Modify the dumper > so that it returns -EMSGSIZE when a filter fails to dump and it is the > first filter in the skb. If we are not first, we will get a next chance > with more room. > > I understand this is pretty near to being an API change, but the > original design (silent truncation) can be considered a bug. > > Note: The error case can happen pretty easily if you create a filter > with 32 actions and have 4kb pages. Also recent versions of iproute try > to be clever with their buffer allocation size, which in turn leads to > > Signed-off-by: Roman Kapl <c...@rkapl.cz>
Acked-by: Cong Wang <xiyou.wangc...@gmail.com>
