From: Heiner Kallweit <hkallwe...@gmail.com>
Date: Tue, 20 Feb 2018 07:30:16 +0100

> rtl8169_init_phy() resets the PHY anyway after applying the chip-specific
> PHY configuration. So we don't need to soft-reset the PHY as part of the
> chip-specific configuration.
> 
> Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>

I'm not so comfortable with this.

There are so many r8169 chip variants out there.

And who knows, maybe one of them needs this second PHY reset or due to
some way the driver is coded it is necessary.

Unless you can test this change on every r8169 chip type, I'm very
reluctant to apply this patch.

Sorry.

Reply via email to