On Wed, Feb 28, 2018 at 11:44 PM, Ka-Cheong Poon
<ka-cheong.p...@oracle.com> wrote:
> Commit 0933a578cd55 ("rds: tcp: use sock_create_lite() to create the
> accept socket") has a reference counting issue in TCP socket creation
> when accepting a new connection. The code uses sock_create_lite() to
> create a kernel socket. But it does not do __module_get() on the
> socket owner. When the connection is shutdown and sock_release() is
> called to free the socket, the owner's reference count is decremented
> and becomes incorrect. Note that this bug only shows up when the socket
> owner is configured as a kernel module.
>
> - new_sock->type = sock->type;
> - new_sock->ops = sock->ops;
> ret = sock->ops->accept(sock, new_sock, O_NONBLOCK, true);
> if (ret < 0)
> goto out;
>
> + new_sock->ops = sock->ops;
How is this delta relevant to the commit comment? Seems unrelated?
--Sowmini
