On Mon, Mar 05, 2018 at 08:30:49PM +0100, Heiner Kallweit wrote: > All callers of phy_disable_interrupts() call phy_error() in the error > case. Therefore we don't need to do this within the function too.
> This change also allows us to use phy_disable_interrupts() in code > holding phydev->lock (because phy_error() takes this lock). > Make use of this in phy_stop(). Hi Heiner These are two logically separate changes. Please split them into two patches in one series. Thanks Andrew