On Wed, Mar 14, 2018 at 3:50 AM, Jakub Kicinski <jakub.kicin...@netronome.com> wrote: > On Tue, 13 Mar 2018 17:53:39 +0200, Or Gerlitz wrote: >> > Starting with type 2, in our current NIC HW APIs we have to duplicate >> > these rules >> > into two rules set to HW: >> > >> > 2.1 VF rep --> uplink 0 >> > 2.2 VF rep --> uplink 1 >> > >> > and we do that in the driver (add/del two HW rules, combine the stat >> > results, etc) > > Ack, I think our HW API also will require us to duplicate the rules > today, but IMHO we should implement some common helper module in the > core that would work for any block sharing rather than bond specific > solution.
To be clear, you refer to the case where the bond is the egress device of the rule? For the case the bond is the ingress device, RU OK with the approach Jiri suggested to propagate the tc setup ndo call into the lower devices? so they are bind/unbinding for any block the upper is. This approach is applicable for bond/team/vlan devices for both NIC and Switch ASIC (or NPU...) drivers. You want to make a helper out of this?