From: Patrick McHardy <[EMAIL PROTECTED]> Date: Sat, 02 Sep 2006 16:46:44 +0200
> [XFRM]: Fix wildcard as tunnel source > > Hashing SAs by source address breaks templates with wildcards as tunnel > source. Remove saddr from the hash key. > > Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> Unfortunately, this break scalability of the xfrm state layer when the source is equally as varying as the destination. In such setups you have an enormous number of entries with destination being the local system and only the source address changing. BTW, how can the source be specified as wildcard? There is no prefix component, it is simply an xfrm_address_t. And there are several macros which check for x->props.saddr equality directly with no special prefixing or wildcard logic. I really don't want to remove this as it's fairly critical performance wise for the scalability problems all my changes were meant to address. I hope I really don't have to do something like what was needed for the policy layer, having a linked list and a hash table to handle the two cases. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
