From: Subash Abhinov Kasiviswanathan <subas...@codeaurora.org> Date: Wed, 14 Mar 2018 13:01:04 -0600
> + if (nla_put_u16(skb, IFLA_VLAN_ID, priv->mux_id)) > + goto nla_put_failure; > + > + port = rmnet_get_port_rtnl(real_dev); > + > + f.flags = port->data_format; > + f.mask = ~0; > + > + if (nla_put(skb, IFLA_VLAN_FLAGS, sizeof(f), &f)) > + goto nla_put_failure; Please don't use VLAN netlink attributes to report rmnet device specific values. Instead, please add appropriate new netlink attributes which clearly show that they are the rmnet mux_id and flags. You'll also need to provide UAPI definitions for these flag bits to go along with the attribute name. Thanks.
