From: Jiri Pirko <j...@mellanox.com> This patchset resolves 2 issues we have right now: 1) There are many netdevices / ports in the system, for port, pf, vf represenatation but the user has no way to see which is which 2) The ndo_get_phys_port_name is implemented in each driver separatelly, which may lead to inconsistent names between drivers.
This patchset introduces port flavours which should address the first problem. I'm testing this with Netronome nfp hardware. When the user has 2 physical ports, 1 pf, and 4 vfs, he should see something like this: # devlink port pci/0000:05:00.0/0: type eth netdev enp5s0np0 flavour physical number 0 pci/0000:05:00.0/268435456: type eth netdev eth0 flavour physical number 0 pci/0000:05:00.0/268435460: type eth netdev enp5s0np1 flavour physical number 1 pci/0000:05:00.0/536875008: type eth netdev eth2 flavour pf_rep number 536875008 pci/0000:05:00.0/536870912: type eth netdev eth1 flavour vf_rep number 0 pci/0000:05:00.0/536870976: type eth netdev eth3 flavour vf_rep number 1 pci/0000:05:00.0/536871040: type eth netdev eth4 flavour vf_rep number 2 pci/0000:05:00.0/536871104: type eth netdev eth5 flavour vf_rep number 3 The indexes are weird numbers now. That needs to be fixed. Also, netdev renaming does not work correctly for me now for some reason. Also, there is one extra port that I don't understand what is the purpose for it - something nfp specific perhaps. The desired output should look like this: # devlink port pci/0000:05:00.0/0: type eth netdev enp5s0np0 flavour physical number 0 pci/0000:05:00.0/1: type eth netdev enp5s0np1 flavour physical number 1 pci/0000:05:00.0/2: type eth netdev enp5s0npf0 flavour pf_rep number 0 pci/0000:05:00.0/3: type eth netdev enp5s0nvf0 flavour vf_rep number 0 pci/0000:05:00.0/4: type eth netdev enp5s0nvf1 flavour vf_rep number 1 pci/0000:05:00.0/5: type eth netdev enp5s0nvf2 flavour vf_rep number 2 pci/0000:05:00.0/6: type eth netdev enp5s0nvf3 flavour vf_rep number 3 As you can see, the netdev names are generated according to the flavour and port number. In case the port is split, the split subnumber is also included. I tested this for mlxsw and nfp. I have no way to test this on DSA hw, I would really appretiate DSA guys to test this. Thanks! Jiri Pirko (12): devlink: introduce devlink_port_attrs_set devlink: extend attrs_set for setting port flavours devlink: introduce a helper to generate physical port names dsa: set devlink port attrs for dsa ports dsa: use devlink helper to generate physical port name mlxsw: use devlink helper to generate physical port name nfp: flower: fix error path during representor creation nfp: set eth_id for representors to avoid port index conflict nfp: register devlink port for VF/PF representors nfp: flower: create port for flower vnic nfp: use devlink helper to generate physical port name nfp: flower: set sysfs link to device for representors drivers/net/ethernet/mellanox/mlxsw/core.c | 18 ++++- drivers/net/ethernet/mellanox/mlxsw/core.h | 5 +- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 21 ++---- drivers/net/ethernet/mellanox/mlxsw/switchx2.c | 11 +-- drivers/net/ethernet/netronome/nfp/flower/main.c | 17 ++++- drivers/net/ethernet/netronome/nfp/nfp_devlink.c | 45 +++++++++-- drivers/net/ethernet/netronome/nfp/nfp_net_repr.c | 19 ++++- drivers/net/ethernet/netronome/nfp/nfp_net_repr.h | 1 + drivers/net/ethernet/netronome/nfp/nfp_port.c | 30 +------- include/net/devlink.h | 32 ++++++-- include/uapi/linux/devlink.h | 22 ++++++ net/core/devlink.c | 92 ++++++++++++++++++++--- net/dsa/dsa2.c | 23 ++++++ net/dsa/slave.c | 6 +- 14 files changed, 252 insertions(+), 90 deletions(-) -- 2.14.3