Re: [PATCH] test_bpf: Fix NULL vs IS_ERR() check in test_skb_segment()

[Yonghong Song]

On 3/28/18 4:48 AM, Dan Carpenter wrote:

The skb_segment() function returns error pointers on error.  It never
returns NULL.

Fixes: 76db8087c4c9 ("net: bpf: add a test for skb_segment in test_bpf module")
Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>

diff --git a/lib/test_bpf.c b/lib/test_bpf.c
index b2badf6b23cd..8e157806df7a 100644
--- a/lib/test_bpf.c
+++ b/lib/test_bpf.c
@@ -6649,7 +6649,7 @@ static __init int test_skb_segment(void)
        }

segs = skb_segment(skb, features);

-       if (segs) {
+       if (!IS_ERR(segs)) {
                kfree_skb_list(segs);
                ret = 0;
                pr_info("%s: success in skb_segment!", __func__);

Oh, my bad. Thanks for the fix!
Reviewed-by: Yonghong Song <y...@fb.com>