On 04/02/2018 05:40 AM, Eran Ben Elisha wrote: > On Sun, Apr 1, 2018 at 7:35 PM, Eric Dumazet <eric.duma...@gmail.com> wrote: >> >> >> On 04/01/2018 06:17 AM, Tariq Toukan wrote: >>> From: Eran Ben Elisha <era...@mellanox.com> >>> >>> Add GRO capability for IPv6 GRE tunnel and ip6erspan tap, via gro_cells >>> infrastructure. >>> >>> Performance testing: 55% higher badwidth. >>> Measuring bandwidth of 1 thread IPv4 TCP traffic over IPv6 GRE tunnel >>> while GRO on the physical interface is disabled. >>> CPU: Intel Xeon E312xx (Sandy Bridge) >>> NIC: Mellanox Technologies MT27700 Family [ConnectX-4] >>> Before (GRO not working in tunnel) : 2.47 Gbits/sec >>> After (GRO working in tunnel) : 3.85 Gbits/sec >>> >>> Signed-off-by: Eran Ben Elisha <era...@mellanox.com> >>> Signed-off-by: Tariq Toukan <tar...@mellanox.com> >>> CC: Eric Dumazet <eduma...@google.com> >>> --- >> >> >> Seems good, but why isn't this handled directly in GRO native layer ? > ip6_tunnel and ip6_gre do not share initialization flow functions (unlike > ipv4). > Changing the ipv6 init infrastructure should not be part of this > patch. we prefer to keep this one minimal, simple and safe.
Looking at gre_gro_receive() and gre_gro_complete() I could not see why they could not be copied/pasted to IPv6. Maybe give more details on the changelog, it is really not obvious.
