On Thu, Mar 22, 2018 at 1:55 PM, Jiri Pirko <j...@resnulli.us> wrote: > From: Jiri Pirko <j...@mellanox.com> > > This patchset resolves 2 issues we have right now: > 1) There are many netdevices / ports in the system, for port, pf, vf > represenatation but the user has no way to see which is which > 2) The ndo_get_phys_port_name is implemented in each driver separatelly, > which may lead to inconsistent names between drivers. > > This patchset introduces port flavours which should address the first > problem. I'm testing this with Netronome nfp hardware. When the user > has 2 physical ports, 1 pf, and 4 vfs, he should see something like this:
J/J (Jiri/Jakub) -- re "2 physical ports, 1 pf, and 4 vfs" --- does NFP exposes one PF for both physical ports? FWIW note that in mlx5 and AFAIK any other device except for mlx4 (...) folks have FPP (Function Per Port) scheme. [..] > The desired output should look like this: > # devlink port > pci/0000:05:00.0/0: type eth netdev enp5s0np0 flavour physical number 0 > pci/0000:05:00.0/1: type eth netdev enp5s0np1 flavour physical number 1 > pci/0000:05:00.0/2: type eth netdev enp5s0npf0 flavour pf_rep number 0 > pci/0000:05:00.0/3: type eth netdev enp5s0nvf0 flavour vf_rep number 0 > pci/0000:05:00.0/4: type eth netdev enp5s0nvf1 flavour vf_rep number 1 > pci/0000:05:00.0/5: type eth netdev enp5s0nvf2 flavour vf_rep number 2 > pci/0000:05:00.0/6: type eth netdev enp5s0nvf3 flavour vf_rep number 3 > As you can see, the netdev names are generated according to the flavour > and port number. In case the port is split, the split subnumber is also > included. What is the purpose/role in getting dev link ports here? is it such that @ the end of the day the driver would do a devlink_port_get_phys_port_name() call in their get phys port name ndo? or we buy more advantages out of doing so? Or.
