Re: [Patch nf] ipvs: initialize tbl->entries in ip_vs_lblc_init_svc()

[Julian Anastasov]

        Hello,

On Mon, 23 Apr 2018, Cong Wang wrote:

> Similarly, tbl->entries is not initialized after kmalloc(),
> therefore causes an uninit-value warning in ip_vs_lblc_check_expire(),
> as reported by syzbot.
> 
> Reported-by: <syzbot+3e9695f147fb529aa...@syzkaller.appspotmail.com>
> Cc: Simon Horman <ho...@verge.net.au>
> Cc: Julian Anastasov <j...@ssi.bg>
> Cc: Pablo Neira Ayuso <pa...@netfilter.org>
> Signed-off-by: Cong Wang <xiyou.wangc...@gmail.com>

        Thanks!

Acked-by: Julian Anastasov <j...@ssi.bg>

> ---
>  net/netfilter/ipvs/ip_vs_lblc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/netfilter/ipvs/ip_vs_lblc.c b/net/netfilter/ipvs/ip_vs_lblc.c
> index 3057e453bf31..83918119ceb8 100644
> --- a/net/netfilter/ipvs/ip_vs_lblc.c
> +++ b/net/netfilter/ipvs/ip_vs_lblc.c
> @@ -371,6 +371,7 @@ static int ip_vs_lblc_init_svc(struct ip_vs_service *svc)
>       tbl->counter = 1;
>       tbl->dead = false;
>       tbl->svc = svc;
> +     atomic_set(&tbl->entries, 0);
>  
>       /*
>        *    Hook periodic timer for garbage collection
> -- 
> 2.13.0

Regards

--
Julian Anastasov <j...@ssi.bg>