Hi Florian,
> > v0->v1:
> > * Remove driver version #define
>
> This should be a separate patch of its own, more comment below.
>
OK. Patch should be for net, correct?
> > -static int lan78xx_phy_init(struct lan78xx_net *dev)
> > +static int lan7801_phy_init(struct phy_device **phydev,
> > + struct lan78xx_net *dev)
>
> Passing a **phydev looks really unnecessary here, why don't just return a
> struct phy_device * as a return argument here? If you need to communicate
> a specific return value, you can use ERR_PTR()/PTR_ERR() for that purpose.
>
Done.
> > if (ret < 0) {
> > - netdev_err(dev->net, "fail to register fixup\n");
> > + netdev_err(dev->net, "fail to register fixup
> PHY_KSZ9031RNX\n");
>
> Unrelated message change, that should be a separate commit.
OK.
> > + phydev->is_internal = true;
>
> Uggh you are not really supposed to set that, the matching PHY driver should
> have PHY_IS_INTERNAL in the .flags member to indicate that to the core PHY
> library.
>
OK. Will handle this too in separate patch/commit for net.
Thanks,
Raghu
