Re: [PATCH 2/2] bpf: btf: remove a couple conditions

[Martin KaFai Lau]

On Fri, Apr 27, 2018 at 05:04:59PM +0300, Dan Carpenter wrote:
> We know "err" is zero so we can remove these and pull the code in one
> indent level.
> 
> Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>
Thanks for the simplification!

Acked-by: Martin KaFai Lau <ka...@fb.com>

> ---
> This applies to the BPF tree (linux-next)
> 
> diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c
> index e631b6fd60d3..7cb0905f37c2 100644
> --- a/kernel/bpf/btf.c
> +++ b/kernel/bpf/btf.c
> @@ -1973,16 +1973,14 @@ static struct btf *btf_parse(void __user *btf_data, 
> u32 btf_data_size,
>       if (err)
>               goto errout;
>  
> -     if (!err && log->level && bpf_verifier_log_full(log)) {
> +     if (log->level && bpf_verifier_log_full(log)) {
>               err = -ENOSPC;
>               goto errout;
>       }
>  
> -     if (!err) {
> -             btf_verifier_env_free(env);
> -             btf_get(btf);
> -             return btf;
> -     }
> +     btf_verifier_env_free(env);
> +     btf_get(btf);
> +     return btf;
>  
>  errout:
>       btf_verifier_env_free(env);