Eric Dumazet <eric.duma...@gmail.com> writes: > On 05/01/2018 12:31 PM, Toke Høiland-Jørgensen wrote: > >> Could you comment on specifically what you believe is broken in this, >> please, so I can fix it in the same iteration? >> > > Apart from the various pskb_may_pull() this helper should not change skb > layout. > > Ideally, the skb should be const and you would use > skb_header_pointer() to make clear you do not ever write this skb. > > This would make the reviewer job pretty easy, as no side effect can > possibly happen.
Gotcha. Will fix; thanks :) -Toke
