On Thu, May 3, 2018 at 4:06 AM Tariq Toukan <tar...@mellanox.com> wrote:
> On 03/05/2018 6:25 AM, Eric Dumazet wrote: > > When adding rb-tree for TCP retransmit queue, we inadvertently broke > > TCP autocorking. > > > > tcp_should_autocork() should really check if the rtx queue is not empty. > > > Hi Eric, > We are glad to see that the issue that Tal investigated and reported [1] > is now addressed. > Thanks for doing that! > Tal, let’s perf test to see the effect of this fix. > Best, > Tariq > [1] https://patchwork.ozlabs.org/cover/822218/ Yes, but you never really gave any insights of what exact tests you were running :/ Sometimes the crystal ball is silent, sometimes it gives a hint :)
