> -----Original Message----- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of Joe Perches > Sent: Tuesday, May 08, 2018 10:00 AM > To: Kirsher, Jeffrey T <jeffrey.t.kirs...@intel.com>; da...@davemloft.net > Cc: Keller, Jacob E <jacob.e.kel...@intel.com>; netdev@vger.kernel.org; > nhor...@redhat.com; sassm...@redhat.com; jogre...@redhat.com > Subject: Re: [net-next 2/6] fm10k: reduce duplicate fm10k_stat macro code > > On Mon, 2018-05-07 at 07:45 -0700, Jeff Kirsher wrote: > > Share some of the code for setting up fm10k_stat macros by implementing > > an FM10K_STAT_FIELDS macro which we can use when setting up the type > > specific macros. > [] > > diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c > b/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c > [] > > @@ -11,12 +11,16 @@ struct fm10k_stats { > > int stat_offset; > > };o > > > > -#define FM10K_NETDEV_STAT(_net_stat) { \ > > - .stat_string = #_net_stat, \ > > - .sizeof_stat = FIELD_SIZEOF(struct net_device_stats, _net_stat), \ > > - .stat_offset = offsetof(struct net_device_stats, _net_stat) \ > > +#define FM10K_STAT_FIELDS(_type, _name, _stat) { \ > > + .stat_string = _name, \ > > + .sizeof_stat = FIELD_SIZEOF(_type, _stat), \ > > + .stat_offset = offsetof(_type, _stat) \ > > } > > > > +/* netdevice statistics */ > > +#define FM10K_NETDEV_STAT(_net_stat) \ > > + FM10K_STAT_FIELDS(struct net_device_stats, #_net_stat, _net_stat) > > trivia: > > It's somewhat unusual to use # in a macro argument. > Perhaps this would be slightly easier to understand using __stringify > > #define FM10K_NETDEV_STAT(_net_stat) \ > FM10K_STAT_FIELDS(struct net_device_stats, __stringify(_net_stat), > _net_stat)
Makes sense. Will change. Thanks, Jake
