On 16/05/18 06:54 AM, Davide Caratti wrote:
Similarly to what was done with commit a52956dfc503 ("net sched actions: fix refcnt leak in skbmod"), fix the error path of tcf_vlan_init() to avoid refcnt leaks when wrong value of TCA_VLAN_PUSH_VLAN_PROTOCOL is given.Fixes: 5026c9b1bafc ("net sched: vlan action fix late binding") CC: Roman Mashak <[email protected]> Signed-off-by: Davide Caratti <[email protected]> --- net/sched/act_vlan.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/sched/act_vlan.c b/net/sched/act_vlan.c index 853604685965..1fb39e1f9d07 100644 --- a/net/sched/act_vlan.c +++ b/net/sched/act_vlan.c @@ -161,6 +161,8 @@ static int tcf_vlan_init(struct net *net, struct nlattr *nla, case htons(ETH_P_8021AD): break; default: + if (exists) + tcf_idr_release(*a, bind); return -EPROTONOSUPPORT;
LGTM. Note: 5026c9b1bafc fixed the bug that existed. It missed a few spots like the one here. If there was an "Updates" tag, it would be more appropriate. Acked-by: Jamal Hadi Salim <[email protected]> cheers, jamal
