On Wed 16 May 2018 at 18:10, Davide Caratti <dcara...@redhat.com> wrote: > On Wed, 2018-05-16 at 13:36 -0400, Roman Mashak wrote: >> Vlad Buslov <vla...@mellanox.com> writes: >> >> > On Wed 16 May 2018 at 14:38, Roman Mashak <m...@mojatatu.com> wrote: >> > > On Wed, May 16, 2018 at 2:43 AM, Vlad Buslov <vla...@mellanox.com> wrote: >> > > > > > > > I'm trying to run tdc, but keep getting following error even >> > > > > > > > on clean >> > > > > > > > branch without my patches: >> > > > > > > >> > > > > > > Vlad, not sure if you saw my email: >> > > > > > > Apply Roman's patch and try again >> > > > > > > >> > > > > > > https://marc.info/?l=linux-netdev&m=152639369112020&w=2 >> > > > > > > >> > > > > > > cheers, >> > > > > > > jamal >> > > > > > >> > > > > > With patch applied I get following error: >> > > > > > >> > > > > > Test 7d50: Add skbmod action to set destination mac >> > > > > > exit: 255 0 >> > > > > > dst MAC address <11:22:33:44:55:66> >> > > > > > RTNETLINK answers: No such file or directory >> > > > > > We have an error talking to the kernel >> > > > > > >> > > > > >> > > > > You may actually have broken something with your patches in this >> > > > > case. >> > > > >> > > > Results is for net-next without my patches. >> > > >> > > Do you have skbmod compiled in kernel or as a module? >> > >> > Thanks, already figured out that default config has some actions >> > disabled. >> > Have more errors now. Everything related to ife: >> > >> > Test 7682: Create valid ife encode action with mark and pass control >> > exit: 255 0 >> > IFE type 0xED3E >> > RTNETLINK answers: No such file or directory >> > We have an error talking to the kernel >> > >> > Test ef47: Create valid ife encode action with mark and pipe control >> > exit: 255 0 >> > IFE type 0xED3E >> > RTNETLINK answers: No space left on device >> > We have an error talking to the kernel >> > >> > Test df43: Create valid ife encode action with mark and continue control >> > exit: 255 0 >> > IFE type 0xED3E >> > RTNETLINK answers: No space left on device >> > We have an error talking to the kernel >> > >> > Test e4cf: Create valid ife encode action with mark and drop control >> > exit: 255 0 >> > IFE type 0xED3E >> > RTNETLINK answers: No space left on device >> > We have an error talking to the kernel >> > >> > Test ccba: Create valid ife encode action with mark and reclassify control >> > exit: 255 0 >> > IFE type 0xED3E >> > RTNETLINK answers: No space left on device >> > We have an error talking to the kernel >> > >> > Test a1cf: Create valid ife encode action with mark and jump control >> > exit: 255 0 >> > IFE type 0xED3E >> > RTNETLINK answers: No space left on device >> > We have an error talking to the kernel >> > >> > ... >> > >> > >> >> Please make sure you have these in your kernel config: >> >> CONFIG_NET_ACT_IFE=y >> CONFIG_NET_IFE_SKBMARK=m >> CONFIG_NET_IFE_SKBPRIO=m >> CONFIG_NET_IFE_SKBTCINDEX=m >> >> For tdc to run all the tests, it is assumed that all the supported tc >> actions/filters are enabled and compiled. > hello, > > looking at ife.json, it seems that we have at least 4 typos in > 'teardown'. > > It does > > $TC actions flush action skbedit > > in place of > > $TC actions flush action ife > > On my fedora28 (with fedora28 kernel), fixing them made test 7682 return > 'ok' (and all others in ife category, except ee94, 7ee0 and 0a7d). > > regards,
I can confirm that on net-next kernel version that I use, there are also multiple teardowns of actions type skbedit after actually creating ife action in file ife.json. However, tests pass when I enabled config options that Roman suggested: ok 119 - 7682 # Create valid ife encode action with mark and pass control
